generateSchemaHash: changes necessary for graphql@16.0.0#5664
generateSchemaHash: changes necessary for graphql@16.0.0#5664IvanGoncharov merged 1 commit intoapollographql:mainfrom
Conversation
| const documentAST = parse(introspectionQuery); | ||
| const result = execute(schema, documentAST) as ExecutionResult; | ||
| const document = parse(introspectionQuery); | ||
| const result = execute({ schema, document }) as ExecutionResult<IntrospectionQuery>; |
There was a problem hiding this comment.
Here is the main change: in v16.0.0 we dropped support for positional args to execute.
IvanGoncharov
force-pushed
the
generateSchemaHash
branch
from
d7f7da8 to
7873a4f
Compare
|
Do we need to do what's done in #5663 as well? Or is this just one piece of working towards v16 compatibility? |
glasser
left a comment
glasser
left a comment
There was a problem hiding this comment.
This looks reasonable, though I'm curious how we're testing this.
I update |
|
@IvanGoncharov FYI, I noticed in retrospect that this file didn't have a CHANGELOG entry. Was that intentional, since it doesn't actually get us all the way to graphql 16 compatibility yet? |
|
@glasser Yes, was a partial change. |
2 participants
No description provided.